Emulated Hue climate fix#169681
Draft
andmcg1 wants to merge 1 commit intohome-assistant:devfrom
Draft
Conversation
Alexa shows climate device as "unresponsive" when turned off, as they do not report their setpoint. This fix returns 0 instead. When the climate device is switched on, the temperature shows correctly in Alexa.
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
Bot
added
bugfix
cla-needed
integration: emulated_hue
small-pr
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @bdraco, @Tho85, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes emulated_hue’s Hue API state generation for climate entities so the bri value is always a valid number even when the climate entity’s target temperature is None (e.g., when turned off), avoiding “unresponsive” behavior in Alexa.
Changes:
- Add explicit handling for
ATTR_TEMPERATURE is Nonewhen building the Hue state forclimateentities. - Preserve the existing temperature-to-brightness conversion path when a target temperature is present.
Comment on lines
+725
to
+730
| # Handle climate device that returns null when switched off | ||
| if temperature is None: | ||
| data[STATE_BRIGHTNESS] = 0 | ||
| else: | ||
| # Convert 0-100 to 0-254 | ||
| data[STATE_BRIGHTNESS] = round(temperature * HUE_API_STATE_BRI_MAX / 100) |
Comment on lines
723
to
+730
| if entity.domain == climate.DOMAIN: | ||
| temperature = attributes.get(ATTR_TEMPERATURE, 0) | ||
| # Convert 0-100 to 0-254 | ||
| data[STATE_BRIGHTNESS] = round(temperature * HUE_API_STATE_BRI_MAX / 100) | ||
| # Handle climate device that returns null when switched off | ||
| if temperature is None: | ||
| data[STATE_BRIGHTNESS] = 0 | ||
| else: | ||
| # Convert 0-100 to 0-254 | ||
| data[STATE_BRIGHTNESS] = round(temperature * HUE_API_STATE_BRI_MAX / 100) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alexa shows climate device as "unresponsive" when turned off, as they do not report their setpoint. This fix returns 0 instead. When the climate device is switched on, the temperature shows correctly in Alexa.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: